[HIVE-14514] OrcRecordUpdater should clone writerOptions when creating delete event writers

• Type: Improvement
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.2.0
• Fix Version/s: 4.0.0-alpha-2
• Component/s: Transactions
• Labels: pull-request-available
• Assignee: Dmitriy Fingerman
• Reporter: Saket Saurabh
• Created: 10/Aug/16 20:35
• Updated: 16/Nov/22 13:50
• Resolved: 23/Sep/22 22:26

Description

When split-update is enabled for ACID, OrcRecordUpdater creates two sets of writers: one for the insert deltas and one for the delete deltas. The deleteEventWriter is initialized with similar writerOptions as the normal writer, except that it has a different callback handler. Due to the lack of copy constructor/ clone() method in writerOptions, the same writerOptions object is mutated to specify a different callback for the delete case. Although, this is harmless for now, but it may become a source of confusion and possible error in future. The ideal way to fix this would be to create a clone() method for writerOptions- however this requires that the parent class of WriterOptions in the OrcFile.WriterOptions should implement Cloneable or provide a copy constructor.

Issue Links

• blocks: HIVE-17089 make acid 2.0 the default
• is blocked by: ORC-154 add OrcFile.WriterOptions.clone()
• is related to: HIVE-14035 Enable predicate pushdown to delta files created by ACID Transactions
• links to: GitHub Pull Request #3610