[HIVE-13650] LLAP: Other todo items in LlapTaskUmbilicalExternalClient

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: llap
• Assignee: Unassigned
• Reporter: Jason Dere
• Created: 29/Apr/16 02:38
• Updated: 29/Apr/16 02:38

Description

Other TODOs from LlapTaskUmbilicalExternalClient:

• From submitWork():

  //    // TODO Also send out information saying that the fragment is finishable - if that is not already included in the main fragment.
  //    // This entire call is only required if we're doing more than scans. MRInput has no dependencies and is always finishable
  //    QueryIdentifierProto queryIdentifier = QueryIdentifierProto
  //        .newBuilder()
  //        .setAppIdentifier(submitWorkRequestProto.getApplicationIdString()).setDagIdentifier(submitWorkRequestProto.getFragmentSpec().getDagId())
  //        .build();
  //    LlapDaemonProtocolProtos.SourceStateUpdatedRequestProto sourceStateUpdatedRequest =
  //        LlapDaemonProtocolProtos.SourceStateUpdatedRequestProto.newBuilder().setQueryIdentifier(queryIdentifier).setState(
  //            LlapDaemonProtocolProtos.SourceStateProto.S_SUCCEEDED).
  //            setSrcName(TODO)
  //    communicator.sendSourceStateUpdate(LlapDaemonProtocolProtos.SourceStateUpdatedRequestProto.newBuilder().setQueryIdentifier(submitWorkRequestProto.getFragmentSpec().getFragmentIdentifierString()).set);
  

• HeartbeatCheckTask.run(): If the heartbeat times out and we abandon the LLAP task, we may want to notify the LLAP daemon that we are no longer interested in this task.