[HIVE-12425] OrcRecordUpdater.close(true) leaves the file open

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Not A Problem
• Affects Version/s: 1.0.0
• Fix Version/s: 3.0.0
• Component/s: ORC, Transactions
• Target Version/s: 1.3.0
• Assignee: Eugene Koifman
• Reporter: Eugene Koifman
• Created: 16/Nov/15 22:00
• Updated: 22/May/18 23:59
• Resolved: 13/Jul/17 22:40

Description

public void close(boolean abort) throws IOException {
    if (abort) {
      if (flushLengths == null) {
        fs.delete(path, false);
      }
    } else {
      if (writer != null) writer.close();
    }
    if (flushLengths != null) {
      flushLengths.close();
      fs.delete(getSideFile(path), false);
    }
    writer = null;
  }

While the assumption is that the last txn writing to this file to commit would have called flush(), this still leaves the file open.

cc owen.omalley