[HIVE-12373] Interner should return identical map or list

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: Query Processor
• Assignee: Navis Ryu
• Reporter: Navis Ryu
• Created: 10/Nov/15 00:48
• Updated: 31/Jan/16 22:36

Description

Currently, HiveStringUtils.intern(map/list) returns new instance of map or list. But it would break some usage style of code something like below (it's spark code in HiveMetastoreCatalog)

val serdeParameters = new java.util.HashMap[String, String]()
serdeInfo.setParameters(serdeParameters)
// these properties will be gone
table.serdeProperties.foreach { case (k, v) => serdeParameters.put(k, v) }
p.storage.serdeProperties.foreach { case (k, v) => serdeParameters.put(k, v) }

Luckily for spark, interner was not applied to released version of hive (1.2.0, 1.2.1) by mistake. But it would make problem in someday.

Issue Links

• is related to: HIVE-7975 HS2 memory optimization: Internalizing instance fields of Thrift-generated metastore API classes