[HIVE-10587] ExprNodeColumnDesc should be created with isPartitionColOrVirtualCol true for DP column

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.3.0, 2.0.0
• Component/s: Query Processor
• Assignee: Chaoyu Tang
• Reporter: Chaoyu Tang
• Created: 03/May/15 20:26
• Updated: 16/Feb/16 23:51
• Resolved: 05/May/15 18:27

Description

In SymenticAnalyzer method:
Operator genConversionSelectOperator(String dest, QB qb, Operator input, TableDesc table_desc, DynamicPartitionCtx dpCtx) throws SemanticException
==
The DP column's ExprNodeColumnDesc is created by passing false as the parameter isPartitionColOrVirtualCol value:

      // DP columns starts with tableFields.size()
      for (int i = tableFields.size() + (updating() ? 1 : 0); i < rowFields.size(); ++i) {
        TypeInfo rowFieldTypeInfo = rowFields.get(i).getType();
        ExprNodeDesc column = new ExprNodeColumnDesc(
            rowFieldTypeInfo, rowFields.get(i).getInternalName(), "", false);
        expressions.add(column);
      }

I think it should be true instead.