Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-1040

use sed rather than diff for masking out noise in diff-based tests

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.4.1
    • 0.9.0
    • Testing Infrastructure
    • None
    • Reviewed

    Description

      The current diff -I approach has two problems: (1) it does not allow resolution finer than line-level, so it's impossible to mask out pattern occurrences within a line, and (2) it produces unmasked files, so if you run diff on the command line to compare the result .q.out with the checked-in file, you see the noise.

      My suggestion is to first run sed to replace noise patterns with an unlikely-to-occur string like ZYZZYZVA, and then diff the pre-masked files without using any -I.

      This would require a one-time hit to update all existing .q.out files so that they would contain the pre-masked results.

      Attachments

        1. HIVE-1040.final.patch
          5.36 MB
          John Sichi
        2. ASF.LICENSE.NOT.GRANTED--HIVE-1040.D597.4.patch
          9 kB
          Phabricator
        3. ASF.LICENSE.NOT.GRANTED--HIVE-1040.D597.3.patch
          9 kB
          Phabricator
        4. HIVE-1040.2.patch
          5.47 MB
          Marek Sapota
        5. ASF.LICENSE.NOT.GRANTED--HIVE-1040.D597.2.patch
          5.23 MB
          Phabricator
        6. HIVE-1040-code-patch.patch
          8 kB
          Marek Sapota
        7. ASF.LICENSE.NOT.GRANTED--HIVE-1040.D597.1.patch
          5.19 MB
          Phabricator
        8. HIVE-1040.1.patch
          5.34 MB
          Marek Sapota

        Issue Links

          Activity

            People

              mareksapota_fb Marek Sapota
              jvs John Sichi
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: