[HDFS-7606] Missing null check in INodeFile#getBlocks()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha1
• Fix Version/s: 2.7.0
• Hadoop Flags: Reviewed
• Assignee: Byron Wong
• Reporter: Ted Yu
• Created: 13/Jan/15 20:46
• Updated: 12/May/16 18:12
• Resolved: 16/Jan/15 22:33

Description

    BlockInfo[] snapshotBlocks = diff == null ? getBlocks() : diff.getBlocks();
    if(snapshotBlocks != null)
      return snapshotBlocks;
    // Blocks are not in the current snapshot
    // Find next snapshot with blocks present or return current file blocks
    snapshotBlocks = getDiffs().findLaterSnapshotBlocks(diff.getSnapshotId());

If diff is null and snapshotBlocks is null, NullPointerException would result from the call to diff.getSnapshotId().

Issue Links

• is related to: HDFS-3107 HDFS truncate