[HDFS-6784] Avoid rescan twice in HDFS CacheReplicationMonitor for one FS Op if it calls setNeedsRescan multiple times.

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 3.0.0-alpha1
• Component/s: caching
• Assignee: Yi Liu
• Reporter: Yi Liu
• Created: 30/Jul/14 10:32
• Updated: 12/May/16 18:12
• Resolved: 14/Aug/14 04:56

Description

In HDFS CacheReplicationMonitor, rescan is expensive. Sometimes, setNeedsRescan is called multiple times, for example, in FSNamesystem#modifyCacheDirective, there are 3 times. In monitor thread of CacheReplicationMonitor, if it checks needsRescan is true, rescan will happen, but needsRescan is set to false before real scan. Meanwhile, the 2nd or 3rd time setNeedsResacn may set needsRescan to true. So after the scan finish, in next loop, a new rescan will be triggered, that's not necessary at all and inefficient for rescan twice.