[HDFS-6349] Bound checks missing in FSEditLogOp.AclEditLogUtil

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.5.0
• Target Version/s: 2.5.0
• Assignee: Unassigned
• Reporter: Kihwal Lee
• Created: 07/May/14 18:00
• Updated: 10/Jun/14 18:30
• Resolved: 10/Jun/14 18:30

Description

AclEditLogUtil.read() can throw OutOfMemoryException when it encounters a certain corrupt entry. This is because it reads the size and blindly tries to allocate an ArrayList of that size.

Because of this a test case always dumps the heap. The test doesn't fail since edit log loading catches and "handles" the exception.

Running org.apache.hadoop.hdfs.server.namenode.TestNameNodeRecovery
java.lang.OutOfMemoryError: Java heap space
Dumping heap to java_pid18667.hprof ...
Heap dump file created [43870820 bytes in 0.154 secs]

Issue Links

• duplicates: HDFS-5995 TestFSEditLogLoader#testValidateEditLogWithCorruptBody gets OutOfMemoryError and dumps heap.