|
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12419944/FileContext-hdfs25.patch against trunk revision 816414. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. -1 javac. The applied patch generated 112 javac compiler warnings (more than the trunk's current 111 warnings). +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/33/testReport/ This message is automatically generated. -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12419985/FileContext-hdfs26.patch against trunk revision 816434. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 112 javac compiler warnings (more than the trunk's current 111 warnings). +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/9/testReport/ This message is automatically generated. Cleaned up formatting changes and fixed javac warning.
+1 patch looks good.
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12420057/FileContext-hdfs27.patch against trunk revision 816717. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/35/testReport/ This message is automatically generated. 1. I feel that primitive[Create, Mkdir] should not allow a null permission that gets the default permission. In this case, the user should use the non-primitive APIs.
2. why primitiveMkdir does not have createParent flag? I have committed this. Thanks, Sanjay!
Hi Hairong, I did not see your comments before resolving the issue. Free feel to reopen the issue if necessary.
I was just addressing hairong's feedback (thanks for catching this - an oversight on my side).
The patch works fine. I will file a bug jira and fix it. Integrated in Hadoop-Hdfs-trunk-Commit #44 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/44/
. Support o.a.h.fs.FileContext. Contributed by Sanjay Radia Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #11 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/11/
. Support o.a.h.fs.FileContext. Contributed by Sanjay Radia Integrated in Hadoop-Hdfs-trunk #98 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/98/
Editorial pass over all release notes prior to publication of 0.21.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
http://issues.apache.org/jira/secure/attachment/12419944/FileContext-hdfs25.patch
against trunk revision 815964.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
-1 findbugs. The patch appears to cause Findbugs to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/32/testReport/


Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/32/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/32/console
This message is automatically generated.