Issue Details (XML | Word | Printable)

Key: HDFS-610
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Sanjay Radia
Reporter: Sanjay Radia
Votes: 0
Watchers: 8
Operations

If you were logged in you would be able to see more operations.
Hadoop HDFS

Add support for FileContext

Created: 10/Sep/09 04:39 AM   Updated: 09/Oct/09 06:55 PM
Return to search
Component/s: hdfs client, name-node
Affects Version/s: 0.21.0
Fix Version/s: 0.21.0

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works FileContext-hdfs12.patch 2009-09-10 07:00 AM Sanjay Radia 8 kB
Text File Licensed for inclusion in ASF works FileContext-hdfs14.patch 2009-09-15 12:15 AM Sanjay Radia 4 kB
Text File Licensed for inclusion in ASF works FileContext-hdfs22.patch 2009-09-17 04:31 AM Sanjay Radia 8 kB
Text File Licensed for inclusion in ASF works FileContext-hdfs25.patch 2009-09-17 11:17 PM Sanjay Radia 8 kB
Text File Licensed for inclusion in ASF works FileContext-hdfs26.patch 2009-09-18 08:04 AM Sanjay Radia 9 kB
Text File Licensed for inclusion in ASF works FileContext-hdfs27.patch 2009-09-18 06:20 PM Suresh Srinivas 9 kB
Issue Links:
Blocker
 

Hadoop Flags: Reviewed
Resolution Date: 18/Sep/09 09:14 PM


 Description  « Hide
Add support for FileContext (linked jira)

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Hadoop QA added a comment - 17/Sep/09 11:26 PM
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12419944/FileContext-hdfs25.patch
against trunk revision 815964.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 4 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

-1 javac. The patch appears to cause tar ant target to fail.

-1 findbugs. The patch appears to cause Findbugs to fail.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/32/testReport/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/32/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/32/console

This message is automatically generated.


Hadoop QA added a comment - 18/Sep/09 03:15 AM
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12419944/FileContext-hdfs25.patch
against trunk revision 816414.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 4 new or modified tests.

-1 javadoc. The javadoc tool appears to have generated 1 warning messages.

-1 javac. The applied patch generated 112 javac compiler warnings (more than the trunk's current 111 warnings).

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/33/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/33/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/33/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/33/console

This message is automatically generated.


Hadoop QA added a comment - 18/Sep/09 10:49 AM
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12419985/FileContext-hdfs26.patch
against trunk revision 816434.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 4 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

-1 javac. The applied patch generated 112 javac compiler warnings (more than the trunk's current 111 warnings).

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/9/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/9/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/9/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/9/console

This message is automatically generated.


Suresh Srinivas added a comment - 18/Sep/09 06:20 PM
Cleaned up formatting changes and fixed javac warning.

Tsz Wo (Nicholas), SZE added a comment - 18/Sep/09 06:35 PM
+1 patch looks good.

Hadoop QA added a comment - 18/Sep/09 09:00 PM
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12420057/FileContext-hdfs27.patch
against trunk revision 816717.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/35/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/35/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/35/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/35/console

This message is automatically generated.


Hairong Kuang added a comment - 18/Sep/09 09:11 PM
1. I feel that primitive[Create, Mkdir] should not allow a null permission that gets the default permission. In this case, the user should use the non-primitive APIs.
2. why primitiveMkdir does not have createParent flag?

Tsz Wo (Nicholas), SZE added a comment - 18/Sep/09 09:14 PM
I have committed this. Thanks, Sanjay!

Tsz Wo (Nicholas), SZE added a comment - 18/Sep/09 09:18 PM
Hi Hairong, I did not see your comments before resolving the issue. Free feel to reopen the issue if necessary.

Sanjay Radia added a comment - 18/Sep/09 09:22 PM
I was just addressing hairong's feedback (thanks for catching this - an oversight on my side).
The patch works fine. I will file a bug jira and fix it.

Hudson added a comment - 18/Sep/09 11:46 PM
Integrated in Hadoop-Hdfs-trunk-Commit #44 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/44/)
. Support o.a.h.fs.FileContext. Contributed by Sanjay Radia

Hudson added a comment - 19/Sep/09 02:12 AM
Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #11 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/11/)
. Support o.a.h.fs.FileContext. Contributed by Sanjay Radia

Hudson added a comment - 29/Sep/09 12:45 PM
Integrated in Hadoop-Hdfs-trunk #98 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/98/)

Robert Chansler added a comment - 09/Oct/09 06:55 PM
Editorial pass over all release notes prior to publication of 0.21.