[HDFS-5588] Incorrect values of trash configuration and trash emptier state in namenode log

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.2.0
• Component/s: hdfs-client, namenode
• Release Note: This has already been fixed by HDFS-5560
• Assignee: Unassigned
• Reporter: Adam Kawa
• Created: 02/Dec/13 19:07
• Updated: 24/Jan/14 08:50
• Resolved: 24/Jan/14 08:50

Description

Values of trash configuration and trash emptier state in namenode log are displayed in milliseconds (but it should be seconds). This is very confusing because it makes you feel that Trash does not remove data or the meaning of configuration settings changed.

// org.apache.hadoop.fs.TrashPolicyDefault
  @Override
  public void initialize(Configuration conf, FileSystem fs, Path home) {
    ...
    this.deletionInterval = (long)(conf.getFloat(
        FS_TRASH_INTERVAL_KEY, FS_TRASH_INTERVAL_DEFAULT)
        * MSECS_PER_MINUTE);
    this.emptierInterval = (long)(conf.getFloat(
        FS_TRASH_CHECKPOINT_INTERVAL_KEY, FS_TRASH_CHECKPOINT_INTERVAL_DEFAULT)
        * MSECS_PER_MINUTE);
    LOG.info("Namenode trash configuration: Deletion interval = " +
             this.deletionInterval + " minutes, Emptier interval = " +
             this.emptierInterval + " minutes.");
   }

this.deletionInterval and this.emptierInterval are in miliseconds, but the LOG.info tells that they are in minutes.