|
The first bullet point has to be read as:
– Yahoo! Grid Computing 2CAC 8312 4870 D885 8616 6115 220F 6980 1F27 E622 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12412910/HDFS-475.patch  against trunk revision 792310. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/9/testReport/ This message is automatically generated. The test failure is unrelated to the patch for it has been broken from the very first build of HDFS
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/0/ +1 patch looks good. I will wait for one, two days before committing this.
The patch adds the following high level targets:
In HDFS-483, I implemented some tests which use fi. I have to change the test target as following in order to run the tests. Do you want to add them to your patch?
@@ -318,7 +318,7 @@ <!-- Weaving aspects in place Later on one can run 'ant jar' to create Hadoop jar file with instrumented classes --> - <target name="injectfaults" depends="compile" description="Weaves aspects into precomplied HDFS classes"> + <target name="injectfaults" depends="compile, compile-hdfs-test" description="Weaves aspects into precomplied HDFS classes"> <!-- AspectJ task definition --> <taskdef resource="org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties"> <classpath> @@ -335,7 +335,7 @@ target="${javac.version}" source="${javac.version}" deprecation="${javac.deprecation}"> - <classpath refid="classpath" /> + <classpath refid="test.classpath" /> </iajc> <echo message="Weaving of aspects is finished"/> </target> @@ -500,10 +500,14 @@ <batchtest todir="${test.build.dir}" unless="testcase"> <fileset dir="${test.src.dir}/hdfs" includes="**/${test.include}.java" - excludes="**/${test.exclude}.java" /> + excludes="**/${test.exclude}.java" /> + <fileset dir="${test.src.dir}/aop" + includes="**/${test.include}.java" + excludes="**/${test.exclude}.java" /> </batchtest> <batchtest todir="${test.build.dir}" if="testcase"> <fileset dir="${test.src.dir}/hdfs" includes="**/${testcase}.java"/> + <fileset dir="${test.src.dir}/aop" includes="**/${testcase}.java"/> </batchtest> </junit> <antcall target="checkfailure"/> Looks like that your patch also fixes
The latest patch version includes Nicholas' modifications to include src/test/aop as a source for additional tests (FI specific ones). The only modification I had to make in suggested addition is to replace the dependency of 'injectfaults' target from 'compile' to 'compile-core'.
It doesn't look to me that contrib and ant-tasks are related to the FI anyhow. Please correct me if I'm wrong. ant run-hdfs-test-fi -DTestFiXxx I believe this is the essence of Also, this new version of the patch provides new targets to create dev. and test jar files with included FI instrumentation. Please be advised, that Hudson's test-patch output can't be provided for this patch, because HDFS's Hudson doesn't run new targets right now. Removing unnecessary extra-indentation
Including modifications of the target names as mentioned by
Current list of fault injection targets looks like as follows:
jar-fault-inject Make hadoop-fi.jar jar-hdfs-test-fault-inject Make hadoop-test-fi.jar jar-hdfswithmr-test-fault-inject Make hadoop-hdfswithmr-test-fi.jar jar-test-fault-inject Make hadoop-test.jar files run-test-hdfs-fault-inject Run Fault Injection related hdfs tests run-test-hdfs-with-mr-fault-inject Run hdfs Fault Injection related unit tests that require mapred +1 patch looks good.
Tried all the ant targets listed above. It works fine. Also tried
ant run-test-hdfs-fault-inject -Dtestcase=TestFiDataTransferProtocol with the patch posted in HDFS-483. It works. Note that the patch changes the ant target name as shown below. - <target name="injectfaults" depends="compile" description="Weaves aspects into precomplied HDFS classes"> + <target name="compile-fault-inject" depends="compile-core, compile-hdfs-test"> "injectfaults" was introduced by h475_20090716ignore.patch: add build-fi to the ignore lists.
I have committed this. Thanks, Cos!
Integrated in Hadoop-Hdfs-trunk #25 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/25/
). Add new ant targets for fault injection jars and tests. Contributed by Konstantin Boudnik |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Sub-task
Resolved
Major
Target 'tar' hasn't been altered for I don't see why FI'ed stuff has to be included into the release tarball.