[HDFS-4530] return buffer into direct bufferPool in BlockReaderLocal as possible

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 3.0.0-alpha1
• Component/s: datanode
• Assignee: Liang Xie
• Reporter: Liang Xie
• Created: 26/Feb/13 04:12
• Updated: 12/May/16 18:18
• Resolved: 03/Jul/13 16:28

Description

  public synchronized void close() throws IOException {
    dataIn.close();
    if (checksumIn != null) {
      checksumIn.close();
    }
    if (slowReadBuff != null) {
      bufferPool.returnBuffer(slowReadBuff);
      slowReadBuff = null;
    }
    if (checksumBuff != null) {
      bufferPool.returnBuffer(checksumBuff);
      checksumBuff = null;
    }
    startOffset = -1;
    checksum = null;
  }

If there's an IOException occurred in dataIn.close(), then the slowReadBuff&checksumBuff could not be returned anymore. let's make a trivial change to reduce this risk.

Issue Links

• is superceded by: HDFS-4538 allow use of legacy blockreader