|
[
Permlink
| « Hide
]
Steve Loughran added a comment - 02/Jul/09 04:38 PM - edited
The NN JSP helper is chucking out HTML from some of its methods, not well-formed XML. There's a risk that the content pushed out here is not valid XML.
actually, I'm not so sure about the schema, I just remembered how badly xsd sucks
also,
Attaching new patch. I performed suggestion (2) above. Renaming the page to a .jspx doesn't seem to work. Jasper considers .jspx files via a completely separate parser than .jsp ones; one that seems to have trouble with the presence of <% .. %> and other JSP-isms. This patch also includes a test that starts a MiniDFSCluster, retrieves /dfshealth.xml.jsp, uses a SAX parser to parse the page, and check that the main <cluster>..</cluster> element is present.
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12412528/HDFS-453.2.patch  against trunk revision 790733. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/3/testReport/ This message is automatically generated. The test failures are unrelated. Confusingly, it looks from that test report that only the hdfsproxy component is tested – not HDFS itself?
JSPX pages stop you accidentallly getting too much stuff in front of the <? xml ?> page, and encourage you to create well-formed XML as for all the bits that aren't scriptlet-generated text, your IDE will tell you off in advance, as will the JSP compiler. I'm attaching the .jspx equivalent, which
I've already mentioned in HDFS-91 that JSP content doesn't expire, which will burn anyone monitoring through a proxy server. Ideally we should have a JSP tag library that does this for every page, so there's no need to do it by hand in every JSP page. .jspx equivalent. Not tested, the IDE isn't too unhappy with it though. It is well-formed XML.
attaching example output from /dfshealth.jspx
Attaching updated patch
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12417201/HDFS-453.3.patch against trunk revision 805652. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 98 javac compiler warnings (more than the trunk's current 95 warnings). -1 findbugs. The patch appears to introduce 2 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/76/testReport/ This message is automatically generated. The two new findbugs warnings are introduced by code generated by the JspC compiler.
I accidentally introduced two new uses of deprecated methods; these have been fixed. The third javac warning is the lack of serialUid in an auto-generated class. So this will continue to get a -1 javac warning. JspC introduces a further warning now that we've added a jspx file: [jsp-compile] 09/08/21 14:30:00 WARN compiler.TldLocationsCache: Internal Error: File /WEB-INF/web.xml not found Given that JspC generates the correct web.xml file, is this a problem? The core unit test failure is unrelated. patch #4 was generated incorrectly and won't apply. Here we go.
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12417320/HDFS-453.5.patch against trunk revision 806746. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 96 javac compiler warnings (more than the trunk's current 95 warnings). -1 findbugs. The patch appears to introduce 2 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/79/testReport/ This message is automatically generated. New patch resync'd with trunk
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12420092/HDFS-453.6.patch against trunk revision 816785. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 111 javac compiler warnings (more than the trunk's current 110 warnings). -1 findbugs. The patch appears to introduce 2 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/36/testReport/ This message is automatically generated. Is there a reason this is still waiting to commit?
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
New Feature
Patch Available
Major
XML-based metrics as JSP servlet for NameNode
