[HADOOP-9259] FileSystemContractBaseTest should be less brittle in teardown

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.2, 3.0.0-alpha1
• Component/s: test
• Release Note: fixed in HADOOP-9258
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 16/Jan/13 10:53
• Updated: 18/Aug/16 18:35
• Resolved: 25/Mar/13 13:13

Description

the teardown code in FileSystemContractBaseTest assumes that fs!=null and that it's OK to throw an exception if the delete operation fails. Better to check the fs value and catch and convert an exception in the fs.delete() operation to a LOG.error() instead.

This will stop failures in teardown becoming a distraction from the root causes of the problem (that your FileSystem is broken)

Issue Links

• Is contained by: HADOOP-9258 Add stricter tests to FileSystemContractTestBase
• is related to: HADOOP-13518 backport HADOOP-9258 to branch-2