[HDFS-4047] BPServiceActor has nested shouldRun loops

• Type: Bug
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.0.0-alpha
• Component/s: namenode
• Labels: BB2015-05-TBR
• Assignee: Eli Collins
• Reporter: Eli Collins
• Created: 12/Oct/12 19:27
• Updated: 06/May/15 03:31

Description

BPServiceActor#run and offerService booth have while shouldRun loops. We only need the outer one, ie we can hoist the info log from offerService out to run and remove the while loop.

BPServiceActor#run:

while (shouldRun()) {
  try {
    offerService();
  } catch (Exception ex) {
...

offerService:

while (shouldRun()) {
  try {