[HDFS-4035] LightWeightGSet and LightWeightHashSet increment a volatile without synchronization

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-alpha
• Fix Version/s: 2.0.3-alpha
• Hadoop Flags: Reviewed
• Assignee: Eli Collins
• Reporter: Eli Collins
• Created: 10/Oct/12 23:32
• Updated: 15/Feb/13 13:11
• Resolved: 08/Jan/13 22:55

Description

LightWeightGSet and LightWeightHashSet have a volatile modification field that they use to detect updates while iterating so they can throw a ConcurrentModificationException. Since these "LightWeight" classes are explicitly "not thread safe" (eg access to their members is not synchronized) then the current use is OK, we just need to update findbugsExcludeFile.xml to exclude them.