[HDFS-4033] Miscellaneous findbugs 2 fixes

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-alpha
• Fix Version/s: 2.0.3-alpha
• Hadoop Flags: Reviewed
• Assignee: Eli Collins
• Reporter: Eli Collins
• Created: 10/Oct/12 23:21
• Updated: 15/Feb/13 13:12
• Resolved: 08/Jan/13 22:26

Description

Fix some miscellaneous findbugs 2 warnings:

• Switch statements missing default cases
• Using \n instead of %n in format methods
• A socket close that should use IOUtils#closeSocket that we missed
• A use of SimpleDateFormat that is not threadsafe
• In ReplicaInputStreams it's not clear that we always close the streams we allocate, moving the stream creation into the class where we close them makes that more obvious
• A couple missing null checks