[HDFS-4030] BlockManager excessBlocksCount and postponedMisreplicatedBlocksCount should be AtomicLongs

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-alpha
• Fix Version/s: 2.0.3-alpha
• Component/s: namenode
• Hadoop Flags: Reviewed
• Assignee: Eli Collins
• Reporter: Eli Collins
• Created: 10/Oct/12 23:04
• Updated: 15/Feb/13 13:12
• Resolved: 08/Jan/13 21:37

Description

The BlockManager excessBlocksCount and postponedMisreplicatedBlocksCount fields are currently volatile longs which are incremented, which isn't thread safe. It looks like they're always incremented on paths that hold the NN write lock but it would be easier and less error prone for future changes if we made them AtomicLongs. The other volatile long members are just set in one thread and read in another so they're fine as is.