[HDFS-3676] handleSaslConnection failure doesn't try to renew the correct UGI

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.0.0-alpha
• Assignee: Colin McCabe
• Reporter: Colin McCabe
• Created: 17/Jul/12 23:33
• Updated: 29/Aug/13 19:02

Description

Client.java has this code:

    private synchronized void handleSaslConnectionFailure(
        final int currRetries, final int maxRetries, final Exception ex,
        final Random rand, final UserGroupInformation ugi) throws IOException,
        InterruptedException {
      ugi.doAs(new PrivilegedExceptionAction<Object>() {
        public Object run() throws IOException, InterruptedException {
          final short MAX_BACKOFF = 5000;
          closeConnection();
          disposeSasl();
          if (shouldAuthenticateOverKrb()) {
            if (currRetries < maxRetries) {
              if(LOG.isDebugEnabled()) {
                LOG.debug("Exception encountered while connecting to "
                    + "the server : " + ex);
              }
              // try re-login
              if (UserGroupInformation.isLoginKeytabBased()) {
                UserGroupInformation.getLoginUser().reloginFromKeytab();
              } else {
                UserGroupInformation.getLoginUser().reloginFromTicketCache();
              }

It's not renewing the UGI that had the problem, it's renewing the loginUser.

Issue Links

• relates to: HDFS-3608 fuse_dfs: detect changes in UID ticket cache