[HDFS-3131] Improve TestStorageRestore

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.0, 2.0.0-alpha
• Fix Version/s: 1.1.0
• Labels: newbie
• Target Version/s: 1.1.0
• Hadoop Flags: Reviewed
• Assignee: Brandon Li
• Reporter: Tsz-wo Sze
• Created: 23/Mar/12 01:46
• Updated: 10/Mar/15 04:35
• Resolved: 27/Mar/12 00:15

Description

Aaron has the following comments on TestStorageRestore in HDFS-3127.

1. removeStorageAccess, restoreAccess, and numStorageDirs can all be made private
2. numStorageDirs can be made static
3. Rather than do set(Readable/Executable/Writable), use FileUtil.chmod(...).
4. Please put the contents of the test in a try/finally, with the calls to shutdown the cluster and the 2NN in the finally block.
5. Some lines are over 80 chars.
6. No need for the numDatanodes variable - it's only used in one place.
7. Instead of "xwr" use "rwx", which I think is a more common way of describing permissions.

Issue Links

• is related to: HDFS-3127 failure in recovering removed storage directories should not stop checkpoint process