[HDFS-3015] NamenodeFsck and JspHelper duplicate DFSInputStream#copyBlock and bestNode

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Labels: newbie
• Assignee: Colin McCabe
• Reporter: Eli Collins
• Created: 27/Feb/12 01:51
• Updated: 05/Jul/12 23:34

Description

Both NamenodeFsck and JspHelper duplicate DFSInputStream#copyBlock and bestNode. There should be one shared implementation.

  /*
   * XXX (ab) Bulk of this method is copied verbatim from {@link DFSClient}, which is
   * bad. Both places should be refactored to provide a method to copy blocks
   * around.
   */