[HDFS-13175] Add more information for checking argument in DiskBalancerVolume

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.1.0, 3.0.3
• Component/s: diskbalancer
• Target Version/s: 3.1.0
• Hadoop Flags: Reviewed
• Assignee: Lei (Eddy) Xu
• Reporter: Lei (Eddy) Xu
• Created: 20/Feb/18 21:49
• Updated: 05/Apr/18 20:49
• Resolved: 21/Feb/18 04:15

Description

We have seen the following stack in production

Exception in thread "main" java.lang.IllegalArgumentException
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:72)
	at org.apache.hadoop.hdfs.server.diskbalancer.datamodel.DiskBalancerVolume.setUsed(DiskBalancerVolume.java:268)
	at org.apache.hadoop.hdfs.server.diskbalancer.connectors.DBNameNodeConnector.getVolumeInfoFromStorageReports(DBNameNodeConnector.java:141)
	at org.apache.hadoop.hdfs.server.diskbalancer.connectors.DBNameNodeConnector.getNodes(DBNameNodeConnector.java:90)
	at org.apache.hadoop.hdfs.server.diskbalancer.datamodel.DiskBalancerCluster.readClusterInfo(DiskBalancerCluster.java:132)
	at org.apache.hadoop.hdfs.server.diskbalancer.command.Command.readClusterInfo(Command.java:123)
	at org.apache.hadoop.hdfs.server.diskbalancer.command.PlanCommand.execute(PlanCommand.java:107)

raised from

 public void setUsed(long dfsUsedSpace) {
    Preconditions.checkArgument(dfsUsedSpace < this.getCapacity());
    this.used = dfsUsedSpace;
  }

However, the datanode reports at the very moment were not captured. We should add more information into the stack trace to better diagnose the issue.