[HDFS-13001] Testcase improvement for DFSAdmin

• Type: Improvement
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.9.0, 3.0.0
• Component/s: test, tools
• Assignee: Jianfei Jiang
• Reporter: Jianfei Jiang
• Created: 09/Jan/18 10:45
• Updated: 23/Feb/18 04:46

Description

Testcase improvement for DFSAdmin command. The commands should be tested under following environments:
(1) Both Namenode are up online
(2) NN1 is off offline and NN2 is up online
(3) NN1 is up online and NN2 is down offline
(4) Both Namenode are down offline
The testcases can be improved.

Testcases can be improved like code below.

  private void testExecuteDFSAdminCommand(int nnIndex, String[] command,
      String message) throws Exception {
    setUpHaCluster(false);
    switch (nnIndex) {
      case 0:
        cluster.getDfsCluster().shutdownNameNode(0);
        cluster.getDfsCluster().transitionToActive(1);
        break;
      case 1:
        cluster.getDfsCluster().shutdownNameNode(1);
        cluster.getDfsCluster().transitionToActive(0);
        break;
      case 2:
        cluster.getDfsCluster().shutdownNameNode(0);
        cluster.getDfsCluster().shutdownNameNode(1);
        break;
      default:

    }
    int exitCode = admin.run(command);
    if (nnIndex != 2) {
      assertEquals(err.toString().trim(), 0, exitCode);
      assertOutputMatches(message + newLine);
    } else {
      assertNotEquals(err.toString().trim(), 0, exitCode);
      assertOutputNotMatches(message + newLine);
    }
  }

Issue Links

• is related to: HDFS-12935 Get ambiguous result for DFSAdmin command in HA mode when only one namenode is up