[HDFS-12238] Ozone: Add valid trace ID check in sendCommandAsync

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: HDFS-7240
• Fix Version/s: HDFS-7240
• Component/s: ozone
• Labels: newbie
• Target Version/s: HDFS-7240
• Hadoop Flags: Reviewed
• Assignee: Ajay Kumar
• Reporter: Anu Engineer
• Created: 01/Aug/17 19:45
• Updated: 26/Apr/18 21:53
• Resolved: 16/Aug/17 21:29

Description

In the function XceiverClientHandler#sendCommandAsync we should add a check

   if(StringUtils.isEmpty(request.getTraceID())) {
      throw new IllegalArgumentException("Invalid trace ID");
    }

To ensure that ozone clients always send a valid trace ID. However, when you do that a set of current tests that do add a valid trace ID will fail. So we need to fix these tests too.

  TestContainerMetrics.testContainerMetrics
  TestOzoneContainer.testBothGetandPutSmallFile
  TestOzoneContainer.testCloseContainer
  TestOzoneContainer.testOzoneContainerViaDataNode
  TestOzoneContainer.testXcieverClientAsync
  TestOzoneContainer.testCreateOzoneContainer
  TestOzoneContainer.testDeleteContainer
  TestContainerServer.testClientServer
  TestContainerServer.testClientServerWithContainerDispatcher
  TestKeys.testPutAndGetKeyWithDnRestart

This is based on a comment from vagarychen in HDFS-11580.