[HDFS-10458] getFileEncryptionInfo should return quickly for non-encrypted cluster

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
• Component/s: encryption, namenode
• Labels: encryption namenode scalability
• Target Version/s: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
• Hadoop Flags: Reviewed
• Assignee: Zhe Zhang
• Reporter: Zhe Zhang
• Created: 25/May/16 04:53
• Updated: 25/Aug/16 22:59
• Resolved: 07/Jun/16 17:45

Description

FSDirectory#getFileEncryptionInfo always acquires readLock and checks if the path belongs to an EZ. For a busy system with potentially many listing operations, this could cause locking contention.

I think we should add a call EncryptionZoneManager#hasEncryptionZone() to return whether the system has any EZ. If no EZ at all, getFileEncryptionInfo should return null without readLock.

If hasEncryptionZone is only used in the above scenario, maybe itself doesn't need a readLock – if the system doesn't have any EZ when getFileEncryptionInfo is called on a path, it means the path cannot be encrypted.