[HBASE-9408] Fix proto for ServerName so startcode cannot be negative

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Incomplete
• Affects Version/s: 0.96.0
• Component/s: Protobufs
• Assignee: Unassigned
• Reporter: Michael Stack
• Created: 31/Aug/13 22:16
• Updated: 16/Jun/22 18:01
• Resolved: 16/Jun/22 18:01

Description

From Devaraj on the mailing list:

On Sat, Aug 31, 2013 at 11:23 AM, Devaraj Das <[e-mail]> wrote:
Thanks for making the RC, Stack. I bumped into one thing which I thought I
should bring up in the context of singularity - the ServerName message in
hbase.proto should have the start_code as a signed int. We allow for -1 (
ServerName.NON_STARTCODE) as a start_code. Hence.. Yes it can be worked
around, and, maybe there won't any wire-compat issues if we make the change
later (not sure about it) but I think we should fix it now. What do you
think?

For illustration, here is the proposed fix.

diff --git a/hbase-protocol/src/main/protobuf/hbase.proto
b/hbase-protocol/src/main/protobuf/hbase.proto
index 08061e5..2f9a8d1 100644
--- a/hbase-protocol/src/main/protobuf/hbase.proto
+++ b/hbase-protocol/src/main/protobuf/hbase.proto
@@ -120,7 +120,7 @@ enum CompareType {
 message ServerName {
   required string host_name = 1;
   optional uint32 port = 2;
-  optional uint64 start_code = 3;
+  optional int64 start_code = 3;
 }

Will make this fix in next RC if there is one. Filing against 0.96.1 for now.