[HBASE-9059] Address HBASE-8764 'Some MasterMonitorCallable should retry' review

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Component/s: master
• Assignee: Unassigned
• Reporter: Michael Stack
• Created: 27/Jul/13 16:18
• Updated: 16/Jun/22 17:46
• Resolved: 20/Dec/19 22:29

Description

Jesse came in w/ some review post-commit. Let me address in this followup. Let me paste form our offlist correspondence:

+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionOfflineException.java
@@ -24,7 +24,7 @@ import org.apache.hadoop.hbase.exceptions.RegionException;

/** Thrown when a table can not be located */
@InterfaceAudience.Public
[e-mail]
[e-mail]

Really? Same patch? Come on man - you are doing similar cleanup all over the place (shakes head)...
[e-mail]
+public class RpcRetryingCaller<T> {
Calling this stable as the first time its going in seems a bit presumptuous...

+ this.startTime = EnvironmentEdgeManager.currentTimeMillis();
+ int remaining = (int)(callTimeout - (this.startTime - this.globalStartTime));
+ if (remaining < MIN_RPC_TIMEOUT)

Unknown macro: {+ // If there is no time left, we're trying anyway. It's too late.+ // 0 means no timeout, and it's not the intent here. So we secure both cases by+ // resetting to the minimum.+ remaining = MIN_RPC_TIMEOUT;+ }

+ RpcClient.setRpcTimeout(remaining);

Looks like some new logic... seems reasonable to me, so I'll let it slide this time