[HBASE-7919] Wrong key is used in ServerManager#getServerConnection() to retrieve from Map serverConnections

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.94.0
• Fix Version/s: 0.94.6
• Component/s: master
• Hadoop Flags: Reviewed
• Assignee: Anoop Sam John
• Reporter: Anoop Sam John
• Created: 23/Feb/13 10:58
• Updated: 23/Mar/13 04:53
• Resolved: 23/Feb/13 17:41

Description

ServerManager#getServerConnection() try to retrieve the cached connection from Map serverConnections. ServerName objects are the key with which items are saved in this map. But we use String type to get. This always returns null and in turn the Master creates a new connection with RS again and again.

private final Map<ServerName, HRegionInterface> serverConnections =
    new HashMap<ServerName, HRegionInterface>();
...........
private HRegionInterface getServerConnection(final ServerName sn)
  throws IOException {
    HRegionInterface hri = this.serverConnections.get(sn.toString());
    if (hri == null) {
      LOG.debug("New connection to " + sn.toString());
      hri = this.connection.getHRegionConnection(sn.getHostname(), sn.getPort());
      this.serverConnections.put(sn, hri);
    }
    return hri;
  }