[HBASE-7859] errors from creating ZK offline node are not handled

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Assignee: Unassigned
• Reporter: Sergey Shelukhin
• Created: 15/Feb/13 19:25
• Updated: 16/Jun/22 05:32
• Resolved: 08/Jan/15 09:59

Description

Quote from HBASE-7799

What i observed was

try {
      ZKAssign.asyncCreateNodeOffline(watcher, state.getRegion(),
        destination, cb, state);
    } catch (KeeperException e) {
      if (e instanceof NodeExistsException) {
        LOG.warn("Node for " + state.getRegion() + " already exists");
      } else {
        server.abort("Unexpected ZK exception creating/setting node OFFLINE", e);
      }
      return false;
    }
return true;

The asyncCreateNodeOffline just always returns true because it does not wait for the callback to take action. Also the callback does not throw NodeExistsException.

In short the catch block is a dead code.

Issue Links

• is duplicated by: HBASE-7906 OfflineCallBack in bulk assignment does not work as expected
• is related to: HBASE-7799 reassigning region stuck in open still may not work correctly due to leftover ZK node