[HBASE-7246] Assignment#nodeChildrenChanged calls listChildrenAndWatchForNewChildren, overloading master & zookeper needlessly

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Incomplete
• Affects Version/s: 0.95.2
• Component/s: master, Region Assignment
• Assignee: Unassigned
• Reporter: Nicolas Liochon
• Created: 30/Nov/12 17:41
• Updated: 15/Jun/22 17:30
• Resolved: 15/Jun/22 17:30

Description

Assignment#nodeChildrenChanged listens to change event on hbase/unassigned, then calls listChildrenAndWatchForNewChildren. As its name says, this function gets the whole list of unnasigned regions from ZK.

The internal comments says it's only for split creation. I tried to remove it, it seems to work.

The point is:

• ZK does not allow us to know upfront if it's a split or not
• 50% of the events will be deletions, we don't care about them but we can't know in advance
• for large assignment, we will have a lot of children (hence events). Common practise in ZK is to limit the number of subnodes (see the threads http://www.mail-archive.com/[e-mail]/msg01954.html)

Monitoring the master, it was spending 10% of it's time on this during assignment. It seems it was not on the critical path (yet...), so removing it did not change the overall performances on a test scenario. In real life however, this typically adds workload to ZK, and ZK workload is precious on large failures... Same as master actually.

If it's used only for split, we should have a znode specific for split and not a global znode.

Issue Links

• is required by: HBASE-5843 Improve HBase MTTR - Mean Time To Recover