[HBASE-7137] Improve Bytes to accept byte buffers which don't allow us to directly access their backing arrays

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.95.2
• Fix Version/s: 0.95.0
• Hadoop Flags: Reviewed
• Assignee: Hiroshi Ikeda
• Reporter: Hiroshi Ikeda
• Created: 09/Nov/12 10:13
• Updated: 23/Sep/13 18:30
• Resolved: 03/Dec/12 22:05

Description

Inside HBase, it seems that there is the implicit assumption that byte buffers have backed arrays and are not read-only, and we can freely call ByteBuffer.array() and arrayOffset() without runtime exceptions.

But some classes, including Bytes, are supposed to be used by users from outside of HBase, and we should think the possibility that methods receive byte buffers which don't hold the assumption.