[HBASE-7088] Duplicate code in RowCounter

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.96.1, 0.94.14, 0.98.1, 0.99.0
• Fix Version/s: 0.99.0
• Component/s: mapreduce
• Labels: mapreduce
• Hadoop Flags: Reviewed
• Assignee: Jean-Marc Spaggiari
• Reporter: Jean-Marc Spaggiari
• Created: 02/Nov/12 19:31
• Updated: 21/Feb/15 23:35
• Resolved: 18/Dec/13 23:12

Description

On the RowCounter mapreduce class, there is a "scan.setFilter(new FirstKeyOnlyFilter());" statement which is not required at line 125 since we have this on line 141:

    if (qualifiers.size() == 0) {
      scan.setFilter(new FirstKeyOnlyFilter());
    } else {
      scan.setFilter(new FirstKeyValueMatchingQualifiersFilter(qualifiers));
    }

Should the line 125 simply be removed?