[HBASE-6677] Random ZooKeeper port in test can overrun max port

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.95.2
• Fix Version/s: 0.95.0
• Component/s: test
• Hadoop Flags: Reviewed
• Assignee: Liang Xie
• Reporter: Gregory Chanan
• Created: 28/Aug/12 17:51
• Updated: 05/Aug/14 20:11
• Resolved: 20/Sep/12 17:38

Description

 
     while (true) {
        try {
          standaloneServerFactory = new NIOServerCnxnFactory();
          standaloneServerFactory.configure(
            new InetSocketAddress(tentativePort),
            configuration.getInt(HConstants.ZOOKEEPER_MAX_CLIENT_CNXNS,
              1000));
        } catch (BindException e) {
          LOG.debug("Failed binding ZK Server to client port: " +
              tentativePort);
          // This port is already in use, try to use another.
          tentativePort++;
          continue;
        }
        break;
      }

In the case of failure and all the above ports have already been binded, you can extend past the max port. Need to check against a max value.