[HBASE-6495] HBaseAdmin shouldn't expect HConnection to be an HConnectionImplementation

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.94.1, 0.95.2
• Fix Version/s: 0.95.0
• Hadoop Flags: Incompatible change, Reviewed
• Assignee: Jesse Yates
• Reporter: Jesse Yates
• Created: 02/Aug/12 00:15
• Updated: 23/Sep/13 18:31
• Resolved: 06/Sep/12 05:02

Description

Currently, the HBaseAdmin has a constructor that takes an HConnection, but then immediately casts it to an HConnectionManager.HConnectionImplementation:

  public HBaseAdmin(HConnection connection)
      throws MasterNotRunningException, ZooKeeperConnectionException {
    this.conf = connection.getConfiguration();

    // We want the real class, without showing it our public interface,
    //  hence the cast.
    this.connection = (HConnectionManager.HConnectionImplementation)connection;

However, this breaks the explicit contract in the javadocs and makes it basically impossible to mock out the hbaseadmin.

We need to either make the hbaseadmin use a basic HConnection and optimize for cases where its smarter or bring up the couple of methods in HConnectionManager.HConnectionImplementation to the HConnection interface.