[HBASE-6480] If callQueueSize exceed maxQueueSize, all call will be rejected, do not reject priorityCall

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Assignee: Unassigned
• Reporter: Lijin Bin
• Created: 31/Jul/12 08:21
• Updated: 13/Jun/22 18:58
• Resolved: 21/Apr/15 00:40

Description

Current if the callQueueSize exceed maxQueueSize, all call will be rejected, Should we let the priority Call pass through?

Current:

if ((callSize + callQueueSize.get()) > maxQueueSize) {
  Call callTooBig = xxx
  return ;
}
if (priorityCallQueue != null && getQosLevel(param) > highPriorityLevel) {
  priorityCallQueue.put(call);
  updateCallQueueLenMetrics(priorityCallQueue);
} else {
  callQueue.put(call);              // queue the call; maybe blocked here
  updateCallQueueLenMetrics(callQueue);
}

Should we change it to :

if (priorityCallQueue != null && getQosLevel(param) > highPriorityLevel) {
  priorityCallQueue.put(call);
  updateCallQueueLenMetrics(priorityCallQueue);
} else {
  if ((callSize + callQueueSize.get()) > maxQueueSize) {
   Call callTooBig = xxx
   return ;
  }
  callQueue.put(call);              // queue the call; maybe blocked here
  updateCallQueueLenMetrics(callQueue);
}