[HBASE-6333] MemStoreScanner {kvsetAtCreation,snapshotAtCreation} should be private and not volatile

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.95.2
• Fix Version/s: 0.95.0
• Hadoop Flags: Reviewed
• Assignee: Gregory Chanan
• Reporter: Gregory Chanan
• Created: 05/Jul/12 23:55
• Updated: 23/Sep/13 18:30
• Resolved: 06/Jul/12 22:30

Description

I was looking over this code and was confused why these variables were volatile, as they don't need to be [the constructor, which is the only place the variables are set, is already protected by a lock].

I doubt this makes much performance difference (I haven't measured); this is more of a documentation difference to say nothing special is going on here .

https://issues.apache.org/jira/browse/HBASE-4485?focusedCommentId=13132733&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13132733 also talks about this, but it doesn't seem to have been implemented.