[HBASE-6108] Use HRegion.closeHRegion instead of HRegion.close() and HRegion.getLog().close()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.95.2
• Fix Version/s: 0.95.0
• Hadoop Flags: Reviewed
• Assignee: Gregory Chanan
• Reporter: Gregory Chanan
• Created: 25/May/12 22:04
• Updated: 23/Sep/13 18:31
• Resolved: 29/May/12 17:12

Description

There are a bunch of places in the code like this:
region.close();
region.getLog().closeAndDelete();

Instead of the better:
HRegion.closeHRegion(region);

We should change these for a few reasons:
1) If we ever need to change the implementation, it's easier to change in one place
2) closeHRegion properly checks for nulls. There are a few places where this could make a difference, for example in TestOpenedRegionHandler.java it's possible that an exception can be thrown before "region" is assigned and thus region.close() could throw an NPE. closeHRegion avoids this issue.