Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-5292

getsize per-CF metric incorrectly counts compaction related reads as well

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.89.20100924
    • 0.94.2
    • None
    • None

    Description

      The per-CF "getsize" metric's intent was to track bytes returned (to HBase clients) per-CF. Note: We already have metrics to track # of HFileBlock's read for compaction vs. non-compaction cases -- e.g., compactionblockreadcnt vs. fsblockreadcnt.

      Currently, the "getsize" metric gets updated for both client initiated Get/Scan operations as well for compaction related reads. The metric is updated in StoreScanner.java:next() when the Scan query matcher returns an INCLUDE* code via a:

      HRegion.incrNumericMetric(this.metricNameGetsize, copyKv.getLength());

      We should not do the above in case of compactions.

      Attachments

        1. jira-HBASE-5292-Prevent-counting-getSize-on-compacti-2012-03-09_13_26_52.patch
          22 kB
          Mikhail Gryzykhin
        2. ASF.LICENSE.NOT.GRANTED--D1617.1.patch
          18 kB
          Phabricator
        3. ASF.LICENSE.NOT.GRANTED--D1527.4.patch
          15 kB
          Phabricator
        4. ASF.LICENSE.NOT.GRANTED--D1527.3.patch
          15 kB
          Phabricator
        5. ASF.LICENSE.NOT.GRANTED--D1527.2.patch
          15 kB
          Phabricator
        6. ASF.LICENSE.NOT.GRANTED--D1527.1.patch
          4 kB
          Phabricator
        7. 5292-0.94.txt
          18 kB
          Lars Hofhansl
        8. 0001-jira-HBASE-5292-Prevent-counting-getSize-on-compacti.patch
          22 kB
          Zhiqiu Kong

        Activity

          People

            Unassigned Unassigned
            kannanm Kannan Muthukkaruppan
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: