[HBASE-3893] HRegion.internalObtainRowLock shouldn't wait forever

• Type: Improvement
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.90.2
• Fix Version/s: 0.90.4
• Hadoop Flags: Reviewed

Release Note

hbase.rowlock.wait.duration has been introduced which controls the duration in milliseconds waiting to acquire row lock.
Default value is 30 seconds.
If row lock cannot be acquired within this duration, no row lock would be obtained.

• Assignee: Ted Yu
• Reporter: Jean-Daniel Cryans
• Created: 17/May/11 18:21
• Updated: 20/Nov/15 12:41
• Resolved: 07/Jul/11 22:02

Description

We just had a weird episode where one user was trying to insert a lot of data with overlapping keys into a single region (all of that is a separate problem), and the region server rapidly filled up all it's handlers + queues with those calls. Basically it wasn't deadlocked but almost.

Worse, now that we have a 60 seconds socket timeout the clients were eventually getting the timeout and then retrying another call to that same region server.

We should have a timeout on lockedRows.wait() in HRegion.internalObtainRowLock in order to survive this better.

Issue Links

• depends upon: HBASE-3894 Thread contention over row locks set monitor
• relates to: HBASE-3894 Thread contention over row locks set monitor