[HBASE-2957] Release row lock when waiting for wal-sync

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 0.20.0
• Component/s: regionserver, wal
• Assignee: Unassigned
• Reporter: Prakash Khemani
• Created: 03/Sep/10 04:55
• Updated: 12/Jun/22 00:10
• Resolved: 16/Jul/14 23:02

Description

Is there a reason to hold on to the row-lock while waiting for the WAL-sync to be completed by the logSyncer thread?

I think data consistency will be guaranteed even if the following happens (a) the row lock is held while the row is updated in memory (b) the row lock is released after queuing the KV record for WAL-syncing (c) the log-sync system guarantees that the log records for any given row are synced in order (d) the HBase client only receives a success notification after the sync completes (no change from the current state)

I think this should be a huge win. For my use case, and I am sure for others, the handler thread spends the bulk of its row-lock critical section time waiting for sync to complete.

Even if the log-sync system cannot guarantee the orderly completion of sync records, the "Don't hold row lock while waiting for sync" option should be available to HBase clients on a per request basis.