[HBASE-2463] Various Bytes.* functions silently ignore invalid arguments

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.90.0
• Component/s: util
• Hadoop Flags: Reviewed
• Assignee: Benoit Sigoure
• Reporter: Benoit Sigoure
• Created: 17/Apr/10 08:55
• Updated: 20/Nov/15 12:42
• Resolved: 18/Apr/10 05:51

Description

Many functions in hbase.util.Bytes silently ignore invalid arguments.
For instance, Bytes.toInt(null) deliberately returns -1. There are tons of cases like that.

• All functions that are given a null pointer should throw an NPE.
• All functions that are given otherwise invalid arguments should throw an IllegalArgumentException.

Anyone relying on "special return values" such as -1 for Bytes.toInt(null) is guilty of writing broken code (-1 is a valid return value for toInt!).