Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-2270

Improve how we handle recursive calls in ExplicitColumnTracker and WildcardColumnTracker

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.90.0
    • None
    • None
    • Reviewed

    Description

      Ryan was saying in HBASE-2259:

      the variable 'recursive' should really be named something more accurate. the continue at the end of the loop should get optimized out, but it looks like bad form. also commented out code should not be in the patch, just remove it.
      since this call is also tail recursive, this should be solvable with a while(true) and return statements only, no boolean necessary. That would be a more straightforward port, so lets do that instead.

      Let's fix ExplicitColumnTracker and WildcardColumnTracker at the same time.

      Attachments

        1. HBASE-2270.patch
          4 kB
          Jean-Daniel Cryans

        Activity

          People

            jdcryans Jean-Daniel Cryans
            jdcryans Jean-Daniel Cryans
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: