Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
None
-
None
-
None
-
Reviewed
Description
Ryan was saying in HBASE-2259:
the variable 'recursive' should really be named something more accurate. the continue at the end of the loop should get optimized out, but it looks like bad form. also commented out code should not be in the patch, just remove it.
since this call is also tail recursive, this should be solvable with a while(true) and return statements only, no boolean necessary. That would be a more straightforward port, so lets do that instead.
Let's fix ExplicitColumnTracker and WildcardColumnTracker at the same time.