[HBASE-22510] Address findbugs/spotbugs complaints (branch-1)

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Hadoop Flags: Reviewed
• Assignee: Andrew Kyle Purtell
• Reporter: Andrew Kyle Purtell
• Created: 30/May/19 17:51
• Updated: 03/Jun/19 21:41
• Resolved: 03/Jun/19 18:30

Description

FindBugs module:hbase-server
Dead store to bypass in org.apache.hadoop.hbase.master.HMaster.listNamespaces() At HMaster.java:org.apache.hadoop.hbase.master.HMaster.listNamespaces() At HMaster.java:[line 3081]
Switch statement found in org.apache.hadoop.hbase.quotas.MasterQuotaManager.applyThrottle(QuotaProtos$Quotas$Builder, QuotaProtos$ThrottleRequest) where one case falls through to the next case At MasterQuotaManager.java:QuotaProtos$ThrottleRequest) where one case falls through to the next case At MasterQuotaManager.java:[lines 444-447]
Possible null pointer dereference of r in org.apache.hadoop.hbase.regionserver.HStore.removeCompactedfiles(Collection) Dereferenced at HStore.java:r in org.apache.hadoop.hbase.regionserver.HStore.removeCompactedfiles(Collection) Dereferenced at HStore.java:[line 2800]
org.apache.hadoop.hbase.util.compaction.MajorCompactor.ERRORS is a mutable collection which should be package protected At MajorCompactor.java:which should be package protected At MajorCompactor.java:[line 72]

Issue Links

• links to: GitHub Pull Request #278