[HBASE-19985] Redundant instanceof check in ProtobufUtil#getServiceException

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.4.1
• Fix Version/s: 1.4.3
• Hadoop Flags: Reviewed
• Assignee: Artem Ervits
• Reporter: Ted Yu
• Created: 12/Feb/18 21:06
• Updated: 01/Feb/19 20:00
• Resolved: 03/Mar/18 10:51

Description

  public static IOException getServiceException(ServiceException e) {
    Throwable t = e;
    if (e instanceof ServiceException) {
      t = e.getCause();

The instanceof check would always return true.

This was reported by https://builds.apache.org/job/PreCommit-HBASE-Build/11495/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html#Warnings_STYLE