[HBASE-19978] The keepalive logic is incomplete in ProcedureExecutor

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-beta-2, 2.0.0

Release Note

Completes keep-alive logic and then enables it; ProcedureExecutor Workers will spin up more threads when need settling back to the core count after the burst in demand has passed. Default keep-alive is one minute. Default core-count is CPUs/4 or 16, which ever is greater. Maximum is an arbitrary core-count * 10 (a limit that should never be hit and if it is, there is something else very wrong).

• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 12/Feb/18 09:27
• Updated: 17/Jun/22 18:12
• Resolved: 20/Feb/18 01:22

Description

The worker thread will just exit after keep alive time, and we never add it back. The only way to add it back is through the stuck checker, this is not correct. Here we should start new worker thread if it is under the core pool size and there are pending procedures.

For now the default keep alive time is Long.MAX_VALUE which means no timeout so no problem, but we do allow users to set it so we need to fix it.

Issue Links

• links to: Review Board