[HBASE-19924] hbase rpc throttling does not work for multi() with request count rater.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.16.0, 1.2.6
• Fix Version/s: 1.3.3, 2.0.0, 1.4.5, 1.2.7
• Component/s: rpc
• Labels: quota throttle
• Assignee: Hua Xiang
• Reporter: Hua Xiang
• Created: 03/Feb/18 03:07
• Updated: 22/Apr/19 16:14
• Resolved: 26/Apr/18 17:57

Description

Basically, rpc throttling does not work for request count based rater for multi. for the following code, when it calls limiter's checkQuota(), numWrites/numReads is lost.

@Override
public void checkQuota(int numWrites, int numReads, int numScans) throws ThrottlingException {
  writeConsumed = estimateConsume(OperationType.MUTATE, numWrites, 100);
  readConsumed = estimateConsume(OperationType.GET, numReads, 100);
  readConsumed += estimateConsume(OperationType.SCAN, numScans, 1000);

  writeAvailable = Long.MAX_VALUE;
  readAvailable = Long.MAX_VALUE;
  for (final QuotaLimiter limiter : limiters) {
    if (limiter.isBypass()) continue;

    limiter.checkQuota(writeConsumed, readConsumed);
    readAvailable = Math.min(readAvailable, limiter.getReadAvailable());
    writeAvailable = Math.min(writeAvailable, limiter.getWriteAvailable());
  }

  for (final QuotaLimiter limiter : limiters) {
    limiter.grabQuota(writeConsumed, readConsumed);
  }
}

Issue Links

• is duplicated by: HBASE-20468 RPC quota requests ineffective due to not counting multi-actions