[HBASE-19531] Remove needless volatile declaration

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Labels: beginner
• Hadoop Flags: Reviewed
• Assignee: Yun-Chi Shih
• Reporter: Chia-Ping Tsai
• Created: 16/Dec/17 11:02
• Updated: 18/Dec/17 19:07
• Resolved: 18/Dec/17 16:47

Description

ZKNamespaceManager.java

public class ZKNamespaceManager extends ZKListener {
  private static final Log LOG = LogFactory.getLog(ZKNamespaceManager.class);
  private final String nsZNode;
  private volatile NavigableMap<String,NamespaceDescriptor> cache; //here

HBaseAdmin.java

public class HBaseAdmin implements Admin {
  private static final Log LOG = LogFactory.getLog(HBaseAdmin.class);

  private ClusterConnection connection;

  private volatile Configuration conf; //here

BufferedMutatorImpl.java

public class BufferedMutatorImpl implements BufferedMutator {

  private static final Log LOG = LogFactory.getLog(BufferedMutatorImpl.class);

  private final ExceptionListener listener;

  private final TableName tableName;

  private final Configuration conf;
  private final ConcurrentLinkedQueue<Mutation> writeAsyncBuffer = new ConcurrentLinkedQueue<>();
  private final AtomicLong currentWriteBufferSize = new AtomicLong(0);
  /**
   * Count the size of {@link BufferedMutatorImpl#writeAsyncBuffer}.
   * The {@link ConcurrentLinkedQueue#size()} is NOT a constant-time operation.
   */
  private final AtomicInteger undealtMutationCount = new AtomicInteger(0);
  private volatile long writeBufferSize;  //here