[HBASE-19367] Refactoring in RegionStates, and RSProcedureDispatcher

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0-beta-1, 2.0.0
• Assignee: Apekshit Sharma
• Reporter: Apekshit Sharma
• Created: 28/Nov/17 20:14
• Updated: 21/Mar/18 22:21
• Resolved: 30/Nov/17 07:03

Description

Working on a bug fix, was in these parts for first time to understand new AM and trying to make sense of things. Did a few improvements on the way.

• Adding javadoc comments
• Bug: ServerStateNode#regions is HashSet but there's no synchronization to prevent concurrent addRegion/removeRegion. Let's use concurrent set instead.
• Use getRegionsInTransitionCount() directly to avoid instead of getRegionsInTransition().size() because the latter copies everything into a new array - what a waste for just the size.
• There's mixed use of getRegionNode and getRegionStateNode for same return type - RegionStateNode. Changing everything to getRegionStateNode. Similarly rename other *RegionNode() fns to *RegionStateNode().
• RegionStateNode#transitionState() return value is useless since it always returns it's first param.
• Other minor improvements

Issue Links

• links to: Review Board (master)