[HBASE-1930] Put.setTimeStamp misleading (doesn't change timestamp on existing KeyValues, not copied in copy constructor)

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.20.0, 0.20.1
• Fix Version/s: 0.90.0
• Component/s: Client
• Hadoop Flags: Reviewed
• Assignee: Unassigned
• Reporter: Dave Latham
• Created: 22/Oct/09 20:39
• Updated: 20/Nov/15 13:01
• Resolved: 23/Oct/09 20:00

Description

In the process of migrating some code from 0.19, and was changing BatchUpdate's to Put's. I was hit by a bit of a gotcha. In the old code, I populated the BatchUpdate, then set the timestamp. However, this doesn't wotk for Put, because Put creates KeyValue's with the currently set timestamp when adding values. Setting the timestamp at the end has no effect. Also, the copy constructor doesn't copy the timestamp (or writeToWAL) setting.

One option would be to simply update the javadoc to make it clear that the timestamp needs to be set prior to adding values. I'm attaching a proposed patch which moves the timestamp setting to constructor only so that it isn't possible to trigger the confusing case at all.

Issue Links

• relates to: HBASE-1941 Put's copy feature has a bug.